Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rlang minimum version #444

Closed
igordot opened this issue Nov 21, 2018 · 4 comments
Closed

rlang minimum version #444

igordot opened this issue Nov 21, 2018 · 4 comments

Comments

@igordot
Copy link

igordot commented Nov 21, 2018

You should add a minimum version for rlang in DESCRIPTION. I got an error installing styler 1.1.0. It was resolved by updating rlang to the latest version (0.3). I forgot to record the exact error I got, but it was environment-related. For example, you use rlang::new_environment() which was added in 0.1.1, so it would have to be at least that recent.

@lorenzwalthert
Copy link
Collaborator

Thanks. Indeed you are right:

# remotes::install_github("lorenzwalthert/namespaces")
namespaces::find_first_release("rlang", "new_environment")
#> [1] "0.1.1"

Created on 2018-11-22 by the reprex package (v0.2.1)

@lorenzwalthert
Copy link
Collaborator

lorenzwalthert commented Nov 21, 2018

Closed with 8ee486c.

@igordot
Copy link
Author

igordot commented Nov 21, 2018

Oh wow! I didn't know about namespaces::find_first_release(). It seems like something that should be in usethis or testthat.

@lorenzwalthert
Copy link
Collaborator

It was a toy project so far, but it indeed might prove useful. However, it still can only handle standard exports, has no unit tests etc. Maybe it could be imported by another package if it is more mature. Also, it needs to do binary search on the NAMESPACE file of all releases for a package via
the GitHub API for https://github.com/cran, which is not very elegant, but I am not sure what else to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants