Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't cache stylerignore sequences #609

Merged
merged 1 commit into from
Feb 22, 2020

Conversation

lorenzwalthert
Copy link
Collaborator

@lorenzwalthert lorenzwalthert commented Feb 22, 2020

When caching by expression, we need to parse again and add_stylerignore() to then drop these text before caching. Closes #608.

@codecov-io
Copy link

codecov-io commented Feb 22, 2020

Codecov Report

Merging #609 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #609      +/-   ##
==========================================
+ Coverage   90.46%   90.47%   +0.01%     
==========================================
  Files          47       47              
  Lines        2128     2132       +4     
==========================================
+ Hits         1925     1929       +4     
  Misses        203      203
Impacted Files Coverage Δ
R/utils-cache.R 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0797fc8...d895999. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

styler caches styler ignore sequences
2 participants