Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare exampleif #748

Merged
merged 3 commits into from Mar 11, 2021
Merged

Prepare exampleif #748

merged 3 commits into from Mar 11, 2021

Conversation

lorenzwalthert
Copy link
Collaborator

@lorenzwalthert lorenzwalthert commented Mar 10, 2021 •
edited

Closes #746 and #747.

  • cache_applying: 0.03 -> 0.03 (-0.3%)
  • cache_recording: 1.2 -> 1.2 (-0.2%)
  • without_cache: 3.48 -> 3.5 (0.5%)

@lorenzwalthert
process @examples one by one
582343b 
this will be necessary since you could theoretically have @example followed by @exampleIf
@lorenzwalthert
adapt tests
fd0e613
@lorenzwalthert
preseve missing line break after @examples
5740662
@lorenzwalthert lorenzwalthert merged commit e9fdbcd into r-lib:master Mar 11, 2021
@lorenzwalthert lorenzwalthert deleted the prepare-exampleif branch March 11, 2021 07:59
This was referenced Mar 11, 2021
Closed
Closed
lorenzwalthert added a commit that referenced this pull request Mar 11, 2021
@lorenzwalthert
parse_roxygen does not get more than one @example tag anymore, as int…
e53c8c6 
…roduced in #748
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Roxygen code example is always moved to next line when on same line with tag
1 participant
@lorenzwalthert