Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow comments in roxygen comment blocks #830

Merged
merged 5 commits into from
Aug 9, 2021

Conversation

lorenzwalthert
Copy link
Collaborator

@lorenzwalthert lorenzwalthert commented Aug 7, 2021

Closes #828, but more generally adds support for random comments in roxygen code blocks. Cases were internally distinct in emulate_rd() depending on the presence of special characters like %, which is why only a %>% triggered a problem.

@codecov-commenter
Copy link

codecov-commenter commented Aug 7, 2021

Codecov Report

Merging #830 (2444974) into master (66ce587) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #830      +/-   ##
==========================================
+ Coverage   90.49%   90.53%   +0.03%     
==========================================
  Files          47       47              
  Lines        2441     2451      +10     
==========================================
+ Hits         2209     2219      +10     
  Misses        232      232              
Impacted Files Coverage Δ
R/roxygen-examples-add-remove.R 95.45% <100.00%> (+3.14%) ⬆️
R/roxygen-examples-parse.R 96.72% <100.00%> (+0.05%) ⬆️
R/roxygen-examples.R 97.91% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66ce587...2444974. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2021

This is how benchmark results would change (along with a 95% confience interval in relative change) if 8468581 is merged into master:

  • cache_applying: 0.1s -> 0.1s [-3.91%, +7.47%]
  • cache_recording: 1.44s -> 1.44s [-0.86%, +1.27%]
  • without_cache: 3.68s -> 3.68s [-1.01%, +1.05%]

Further explanation regarding interpretation and methodology can be found in the documentation.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2021

This is how benchmark results would change (along with a 95% confience interval in relative change) if fa83546 is merged into master:

  • cache_applying: 0.09s -> 0.09s [-5.82%, +4.83%]
  • cache_recording: 1.13s -> 1.13s [-0.27%, +0.95%]
  • without_cache: 2.86s -> 2.84s [-0.75%, -0.04%]

Further explanation regarding interpretation and methodology can be found in the documentation.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2021

This is how benchmark results would change (along with a 95% confience interval in relative change) if 8812fe5 is merged into master:

  • cache_applying: 0.09s -> 0.09s [-4.09%, +5.69%]
  • cache_recording: 1.06s -> 1.05s [-3.01%, -0.21%]
  • without_cache: 2.65s -> 2.66s [-0.66%, +0.97%]

Further explanation regarding interpretation and methodology can be found in the documentation.

@lorenzwalthert lorenzwalthert merged commit 027d5b1 into r-lib:master Aug 9, 2021
@lorenzwalthert lorenzwalthert deleted the issue-828 branch August 9, 2021 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@examplesIf sometimes removing # nolint end
2 participants