-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide a way to start context for extention packages #1082
Comments
Hmmm maybe the right thing to do is export something like But we should also talk about what you’re doing in vdiffr because I’ve been thinking that the new snapshot functions (not implemented yet) should be designed to be extensible so vdiffr could become much simpler. |
Honestly, I don't know well about the internals of vdiffr. I just wanted to remove all |
Ok, I just wanted to make sure you weren't doing a bunch of work on vdiffr that I was about to make obsolete 😄 |
Thanks! |
I'm implementing r-lib/vdiffr#88 to let vdiffr get rid of explicit
context()
. At the time of starting it, I thought I just can usetestthat::context()
insidestart_test()
. But, nowcontext()
is deprecated, andProgressReporter
uses an unexported functionstart_context()
. So, now I don't know what to do.testthat/R/reporter-progress.R
Lines 74 to 81 in d07d805
Are there any way for external packages to do the same thing as
ProgressReporter
does? Or, more broadly, what is the supposed way of implementing a custom reporter at the moment...?The text was updated successfully, but these errors were encountered: