Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sanity check for page anchors #22

Open
AshesITR opened this issue Apr 3, 2022 · 1 comment
Open

Add sanity check for page anchors #22

AshesITR opened this issue Apr 3, 2022 · 1 comment
Labels
feature a feature request or enhancement

Comments

@AshesITR
Copy link

AshesITR commented Apr 3, 2022

It would be nice if not only the URLs are checked, but also existence of page anchors in the returned page if those are present.

e.g. for https://style.tidyverse.org/functions.html#long-lines-1

Check that

  1. The HTTP Status of https://style.tidyverse.org/functions.html is 200
  2. The HTML of https://style.tidyverse.org/functions.html#long-lines-1 has a match for the XPath //*[@id = 'long-lines-1']
@gaborcsardi
Copy link
Member

AFAIR, we are not actually downloading the target URLs, unless the HEAD request we perform fails.

Another thing is that we try to follow what base R does, we actually use the same code. So maybe you could suggest this feature for base R, to see if they want to have it.

@gaborcsardi gaborcsardi added the feature a feature request or enhancement label Apr 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature a feature request or enhancement
Projects
None yet
Development

No branches or pull requests

2 participants