Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate use_github_actions()? #1724

Closed
hadley opened this issue Jan 11, 2023 · 3 comments · Fixed by #1737
Closed

Deprecate use_github_actions()? #1724

hadley opened this issue Jan 11, 2023 · 3 comments · Fixed by #1737
Labels
git git, GitHub, and CI in general upkeep maintenance, infrastructure, and similar

Comments

@hadley
Copy link
Member

hadley commented Jan 11, 2023

Since it's just a thin wrapper around use_github_action_check_release() with a less informative name. (And that's not a workflow we'd generally recommend anyway, since it only checks on linux)

@hadley
Copy link
Member Author

hadley commented Jan 11, 2023

Or make it do something more useful.

In that case, we might want to deprecate use_github_action_check_release() since it's of relatively limited use, and it always confuses me.

@jennybc jennybc added the git git, GitHub, and CI in general label Jan 11, 2023
@malcolmbarrett
Copy link
Collaborator

malcolmbarrett commented Jan 12, 2023

I also don't like that there is only a one-letter difference between this and the much more useful use_github_action()

@jennybc
Copy link
Member

jennybc commented Jan 12, 2023

If we keep the function name and decide to make it more useful, it might be a good candidate for a menu. Sort of like use_version(). Where it takes a look at the project and suggests some actions to configure.

@hadley hadley added the upkeep maintenance, infrastructure, and similar label Jan 17, 2023
@hadley hadley added this to the v2.2.0 milestone Jan 18, 2023
@hadley hadley closed this as completed in 26a843c Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
git git, GitHub, and CI in general upkeep maintenance, infrastructure, and similar
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants