Skip to content

use_version() leaves behind development header if preceding newlines exist in NEWS #1976

@kevinushey

Description

@kevinushey

In renv, I had a NEWS file with the structure:


# renv (development version)

* Fixed an issue where downloads could fail with curl >= 8.7.1. (#1869)

< ... >

Note the leading empty line. When I then ran usethis::use_version("patch"), the NEWS file was modified as:

diff --git a/NEWS.md b/NEWS.md
index bc58b2c79..d2b02c0da 100644
--- a/NEWS.md
+++ b/NEWS.md
@@ -1,3 +1,5 @@
+# renv 1.0.6
+

 # renv (development version)

Note that the old development version NEWS header was unexpectedly retained. Could the check in:

usethis/R/news.R

Lines 49 to 55 in 9e64daf

development_title <- glue("# {project_name()} (development version)")
if (development_title == news[[1]]) {
news[[1]] <- title
ui_bullets(c("v" = "Replacing development heading in {.path NEWS.md}."))
return(write_utf8(news_path, news))
}

skip leading whitespace / empty lines?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions