Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use_gpl3_license does not create GPL3+ file LICENSE like MIT #683

Closed
sriharitn opened this issue Apr 1, 2019 · 5 comments

Comments

@sriharitn
Copy link

commented Apr 1, 2019

When we use, use_gpl3_license() the description file does not contain CRAN compliant License: GPL-3 + file LICENSE in description file.

Without this feature, when we run R CMD check --as-cran mypackage we get the following NOTE:

* checking top-level files ... NOTE
File
  LICENSE

Having use_gpl3_license() output GPL-3+ file LICENSE in description file would be very helpful similar to the output of use_mit_license()

@jennybc

This comment has been minimized.

Copy link
Member

commented Apr 1, 2019

Would you like to fix this in a pull request?

@sriharitn

This comment has been minimized.

Copy link
Author

commented Apr 1, 2019

Yes please that would be great.

@jennybc jennybc added this to the Backlog milestone Apr 3, 2019

@jennybc jennybc removed this from the Backlog milestone Apr 10, 2019

@hadley

This comment has been minimized.

Copy link
Member

commented Apr 29, 2019

LICENSE should automatically be added to .Rbuildignore and the existing code looks correct to me.

@jennybc

This comment has been minimized.

Copy link
Member

commented Jul 3, 2019

I consider this fair game for tidyverse dev day. Removing the WIP label.

@jennybc jennybc added tidy-dev-day 🤓 and removed wip labels Jul 3, 2019

@jennybc

This comment has been minimized.

Copy link
Member

commented Jul 8, 2019

Question from Cervan: Should I do this for other licenses while I'm working on it?

Answer: Search in Writing R Extensions to see if GPL-3 is the only one that needs this treatment (besides MIT).

@jennybc jennybc closed this in f48e100 Jul 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.