Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test-partial-factor fails on big-endian machines #1353

Closed
QuLogic opened this issue Apr 6, 2021 · 3 comments
Closed

test-partial-factor fails on big-endian machines #1353

QuLogic opened this issue Apr 6, 2021 · 3 comments

Comments

@QuLogic
Copy link
Contributor

QuLogic commented Apr 6, 2021

... because rlang::hash is not endian-safe, unlike digest::digest was:

Running the tests in ‘tests/testthat.R’ failed.
Last 13 lines of output:
  `new`: "partial_factor<" "  fa16b {partial}" ">"
  ── Failure (test-partial-factor.R:10:3): has ok print method ───────────────────
  Results have changed from known value recorded in 'test-partial-factor-print-both.txt'.
  
  `old`: "partial_factor<" "  bf275 {partial}" "  fd1ad" ">"
  `new`: "partial_factor<" "  fa16b {partial}" "  31927" ">"
  ── Failure (test-partial-factor.R:22:3): has ok print method ───────────────────
  Results have changed from known value recorded in 'test-partial-factor-print-learned.txt'.
  
  `old`: "partial_factor<" "  fd1ad" ">"
  `new`: "partial_factor<" "  31927" ">"
  
  [ FAIL 5 | WARN 0 | SKIP 34 | PASS 4128 ]
  Error: Test failures
  Execution halted
@hadley
Copy link
Member

hadley commented Apr 6, 2021

We don't support big endian platforms at this time.

@QuLogic
Copy link
Contributor Author

QuLogic commented Apr 7, 2021

I will just skip the test then; do you want a PR to do so? (Though note, everything pass tests on big endian otherwise, even this one when it used to use digest.)

@lionel-
Copy link
Member

lionel- commented Sep 12, 2022

If that helps you're welcome to send a PR to skip tests failing on big endian.

@lionel- lionel- closed this as not planned Won't fix, can't repro, duplicate, stale Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants