Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconsider vec_ptype_abbr() for factor and complex #323

Closed
krlmlr opened this issue May 8, 2019 · 1 comment · Fixed by #324
Closed

Reconsider vec_ptype_abbr() for factor and complex #323

krlmlr opened this issue May 8, 2019 · 1 comment · Fixed by #324

Comments

@krlmlr
Copy link
Member

krlmlr commented May 8, 2019

After switching to vec_ptype_abbr() in {pillar}, two downstream packages now fail their checks. This is mostly due to the change from "fct" to "fctr" and "cpl" to "cplx" .

type_sum() moved away from "fctr" and "cplx" just over a year ago: r-lib/pillar#80, suggested in r-lib/pillar#71. It feels inconsistent that now vec_ptype_abbr() returns "fctr" and "cplx" .

@lionel- @hadley: Can we please move to "fct" and "cpl" here to save quite a few headaches downstream?

Thanks to @nacnudus for pointing this out: nacnudus/unpivotr#24 (comment).

@hadley
Copy link
Member

hadley commented May 8, 2019

Yeah, that's fine with me. Want to do a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants