compare() doesn't know how to show the difference for numbers that round up to the same value

[bakaburg1]

Hello,

I guess this is the intended behaviour but I can't understand the logic:

if I compare numbers that round up to the same value I get this message:

> waldo::compare(c(1, 1.9343), c(1, 1.92))
old != new but don't know how to show the difference

while if they round up to different values I get:

> waldo::compare(c(1, 1.2), c(1, 1.92))
`old`: 1 1
`new`: 1 2

that is, the values get rounded up.

If I use waldo:::diff_element() the output is correct:

> waldo:::diff_element(c(1, 1.9343), c(1, 1.92))
`x`: "1" "1.9343"
`y`: "1" "1.92"  

The problem is that I discovered this behavior in testthat::expect_equal() so I cannot control how the comparison output is managed internally.

[hadley]

This is a bug — probably in my logic that tries to determine the minimum number of decimal places to display.

[hadley]

Another example: waldo::compare(0.21,0.23)