Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

with_namespace, local_namespace: Propagate warn.conflicts #185

Merged
merged 1 commit into from Feb 24, 2022

Conversation

kyleam
Copy link
Contributor

@kyleam kyleam commented Dec 21, 2021

When with_namespace() and local_namespace() gained a warn.conflicts
parameter in 4636e74 (Do not warn about conflicts by default,
2017-11-15), the underlying attach() calls were updated to pass a
hard-coded warn.conflicts = FALSE. This was presumably
unintentional because 1) there's no comment or documentation about why
these functions expose warn.conflicts while ignoring it and 2) all
other functions in namespace.R propagate this argument.

Make with_namespace() and local_namespace() pass along the
warn.conflicts argument.

@kyleam
Copy link
Contributor Author

kyleam commented Dec 22, 2021

All of the ci failures look like unrelated errors in the setup-r-dependencies step.

@kyleam kyleam force-pushed the namespace-warn-conflicts-arg branch from ff0b525 to c0d4465 Compare February 5, 2022 00:12
@kyleam
Copy link
Contributor Author

kyleam commented Feb 5, 2022

All of the ci failures look like unrelated errors in the setup-r-dependencies step.

I've rebased to resolve conflicts in NEWS.md, and the latest ci run is all green.

@lionel- lionel- merged commit fe5901c into r-lib:main Feb 24, 2022
@lionel-
Copy link
Member

lionel- commented Feb 24, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants