with_namespace, local_namespace: Propagate warn.conflicts #185
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When with_namespace() and local_namespace() gained a warn.conflicts
parameter in 4636e74 (Do not warn about conflicts by default,
2017-11-15), the underlying attach() calls were updated to pass a
hard-coded
warn.conflicts = FALSE
. This was presumablyunintentional because 1) there's no comment or documentation about why
these functions expose warn.conflicts while ignoring it and 2) all
other functions in namespace.R propagate this argument.
Make with_namespace() and local_namespace() pass along the
warn.conflicts argument.