Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing test in test suite #236

Closed
tillea opened this issue Nov 21, 2023 · 6 comments
Closed

Failing test in test suite #236

tillea opened this issue Nov 21, 2023 · 6 comments

Comments

@tillea
Copy link

tillea commented Nov 21, 2023

Hi,
I intended to upgrade the Debian package of withr to the latest version 2.5.2. Unfortunately there is one failing test in your test suite. We are running the script which boils down to

cd tests
LC_ALL=C.UTF-8 R --no-save < testthat.R

In the full test log you can find the following error output:

══ Failed tests ════════════════════════════════════════════════════════════════
── Error ('test-language.R:5:3'): can temporarily change language ──────────────
<notSubsettableError/error/condition>
Error in `mean[[1]]`: object of type 'closure' is not subsettable
Backtrace:
    ▆
 1. ├─testthat::expect_error(with_lang("fr_FR", "fr", mean[[1]]), "non indiçable") at test-language.R:5:2
 2. │ └─testthat:::expect_condition_matching(...)
 3. │   └─testthat:::quasi_capture(...)
 4. │     ├─testthat (local) .capture(...)
 5. │     │ └─base::withCallingHandlers(...)
 6. │     └─rlang::eval_bare(quo_get_expr(.quo), quo_get_env(.quo))
 7. └─withr:::with_lang("fr_FR", "fr", mean[[1]])
[ FAIL 1 | WARN 2 | SKIP 2 | PASS 364 ]
Error: Test failures

This log is for version 2.5.1 but the result is perfectly the same for 2.5.2
Any idea what might be wrong here?
Kind regards, Andreas.

@tillea
Copy link
Author

tillea commented Jan 9, 2024

Any idea what might cause this test fail?

@lionel-
Copy link
Member

lionel- commented Jan 9, 2024

I'll try and take some time to take a look this week.

@lionel- lionel- closed this as completed in f2db0a8 Jan 9, 2024
@lionel-
Copy link
Member

lionel- commented Jan 9, 2024

@tillea Could you check that this is fixed with the latest dev version please?

@tillea
Copy link
Author

tillea commented Jan 10, 2024

Seems this patch works to ignore the affected test. Due to a Perl transition in Debian I had to tweak the build and did something slightly differently from my test above but I think it is safe to assume that you can tag a new release to fix the reported problem. Thanks a lot, Andreas.

@lionel-
Copy link
Member

lionel- commented Jan 10, 2024

Thanks! We'll likely release within the next 10 days.

@lionel-
Copy link
Member

lionel- commented Jan 16, 2024

On CRAN!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants