Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call par() with no.readonly=TRUE to avoid warning #238

Merged
merged 3 commits into from
Jan 16, 2024

Conversation

MLopez-Ibanez
Copy link
Contributor

@MLopez-Ibanez MLopez-Ibanez commented Dec 15, 2023

Fixes #237

@MLopez-Ibanez MLopez-Ibanez changed the title Call par() with no.readonly=TRUE to avoid warning (#237) Call par() with no.readonly=TRUE to avoid warning Dec 19, 2023
@MLopez-Ibanez
Copy link
Contributor Author

Ping?

@hadley hadley requested a review from lionel- January 9, 2024 22:47
@hadley
Copy link
Member

hadley commented Jan 9, 2024

@MLopez-Ibanez thanks for working on this. After playing around with this for a bit, I think I found a solution that's a bit simpler and more clearly conveys what's happening.

@MLopez-Ibanez
Copy link
Contributor Author

Fine by me. Should I close this?

@hadley
Copy link
Member

hadley commented Jan 10, 2024

No; the solution is in this PR.

@lionel- lionel- merged commit 21e701c into r-lib:main Jan 16, 2024
11 checks passed
@lionel-
Copy link
Member

lionel- commented Jan 16, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

get_par ignores no.readonly
3 participants