Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use expect_snapshot()+error=TRUE over expect_snapshot_error() in tests #414

Open
MichaelChirico opened this issue Nov 2, 2023 · 0 comments · May be fixed by #429
Open

Use expect_snapshot()+error=TRUE over expect_snapshot_error() in tests #414

MichaelChirico opened this issue Nov 2, 2023 · 0 comments · May be fixed by #429
Labels
upkeep maintenance, infrastructure, and similar

Comments

@MichaelChirico
Copy link
Contributor 

          We now prefer `expect_snapshot()` + `error = TRUE` so then you see the code and the error in the snapshot.

Originally posted by @hadley in #412 (comment)
@MichaelChirico MichaelChirico mentioned this issue Nov 2, 2023
Merged
@hadley hadley added the upkeep maintenance, infrastructure, and similar label Nov 3, 2023
@olivroy olivroy linked a pull request Dec 1, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
upkeep maintenance, infrastructure, and similar
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use expect_snapshot(error = TRUE) over expect_snapshot_error() olivroy/xml2
2 participants
@hadley @MichaelChirico