Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't write ScanAngleRank above 90 degrees #33

Closed
2 tasks done
Jean-Romain opened this issue Feb 11, 2019 · 1 comment
Closed
2 tasks done

Can't write ScanAngleRank above 90 degrees #33

Jean-Romain opened this issue Feb 11, 2019 · 1 comment
Assignees
Labels
Enhancement Not actually a bug but a possible improvement

Comments

@Jean-Romain
Copy link
Collaborator

Jean-Romain commented Feb 11, 2019

See also r-lidar/lidR#219. Function check_las_validity could be more tolerant with the specification and allow to write numbers up to 2⁷-1.

  • modify is_valid_ScanAngleRank to allow range of [-127, +127]
  • create is_compliant_ScanAngleRank to warn about rank out of [-90, +90]
library(rlas)
lazfile <- system.file("extdata", "example.laz", package="rlas")
lasdata <- read.las(lazfile)
header  <- read.lasheader(lazfile)
lasdata$ScanAngleRank[1] <- 91L
f <- tempfile(fileext = ".las")
write.las(f, header, lasdata)
#> Error: Invalid data: ScanAngleRank greater than 90

@pobsteta

@Jean-Romain Jean-Romain added the Enhancement Not actually a bug but a possible improvement label Feb 11, 2019
@Jean-Romain Jean-Romain self-assigned this Feb 11, 2019
@Jean-Romain
Copy link
Collaborator Author

@pobsteta install rlas 1.3.2 from github.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Not actually a bug but a possible improvement
Projects
None yet
Development

No branches or pull requests

1 participant