Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compatibility with dev rlang #50

Merged
merged 4 commits into from Oct 24, 2021
Merged

Fix compatibility with dev rlang #50

merged 4 commits into from Oct 24, 2021

Conversation

krlmlr
Copy link
Member

@krlmlr krlmlr commented Oct 17, 2021

CC @lionel-: I'll keep the existing code for compatibility with CRAN rlang. Do you still plan to submit rlang tomorrow?

@codecov-commenter
Copy link

codecov-commenter commented Oct 17, 2021

Codecov Report

Merging #50 (9ac0685) into main (fa2a115) will decrease coverage by 13.78%.
The diff coverage is 4.76%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main      #50       +/-   ##
===========================================
- Coverage   85.57%   71.78%   -13.79%     
===========================================
  Files          13       13               
  Lines         201      241       +40     
===========================================
+ Hits          172      173        +1     
- Misses         29       68       +39     
Impacted Files Coverage Δ
R/add_trace_back.R 60.15% <4.76%> (-26.21%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa2a115...9ac0685. Read the comment docs.

@lionel-
Copy link

lionel- commented Oct 18, 2021

Thanks! No rush, I think we'll have to figure out dplyr errors before releasing rlang

@krlmlr
Copy link
Member Author

krlmlr commented Oct 18, 2021

Thanks. Do you agree with the formatting (printed and internal)? https://github.com/r-prof/winch/pull/50/files#diff-7b00dfdfc2c5031e20f4203b00fa8e5b23417ef687b65cd353737b584a29e8ef

@lionel-
Copy link

lionel- commented Oct 18, 2021

It's fine for now. We might add another column later on to specify the context (reticulate, winch, ...).

Could you perhaps no longer rely on the version attribute? I'd rather not keep it around. Removing it in a future release would also be fine.

@krlmlr krlmlr merged commit a8c4484 into main Oct 24, 2021
@krlmlr krlmlr deleted the b-dev-rlang branch October 24, 2021 04:13
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants