Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timezone information incorrect #27

Closed
HarvsG opened this issue Jul 18, 2017 · 2 comments
Closed

Timezone information incorrect #27

HarvsG opened this issue Jul 18, 2017 · 2 comments
Assignees
@jakewmeyer
Labels
Completed Data Fix

Comments

@HarvsG
Copy link

HarvsG commented Jul 18, 2017 •
edited

After getting some funny javascript behaviour in my server logic I found the issue.
So apparently we got the wrong end of the stick with the ISO datetimes.
For example, Intelsat 35e reads

    "launch_date_utc": "2017-07-05T23:35:00Z",
    "launch_date_local": "2017-07-05T23:35:00-04:00",

But should read

    "launch_date_utc": "2017-07-05T23:35:00Z",
    "launch_date_local": "2017-07-05T19:35:00-04:00",

JSFiddle

So the correct format for a local time is
local_year-local_month-local_dayTlocal_hour:local_minutes:local_seconds+/-timezone_correction
and not UTCDateTime+/-timezone_correction
@jakewmeyer jakewmeyer self-assigned this Jul 18, 2017
@jakewmeyer
Copy link
Member

So it needs the timezone adjustment twice? Weird.

I'll make another pass on it and convert to the correct times. Thanks 👍

@jakewmeyer
Copy link
Member

Local timezones should be correct now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jakewmeyer jakewmeyer

Labels
Completed Data Fix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@HarvsG @jakewmeyer