Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source data is inconsistent #53

Closed
Srokap opened this issue Nov 2, 2017 · 3 comments
Closed

Source data is inconsistent #53

Srokap opened this issue Nov 2, 2017 · 3 comments

Comments

@Srokap
Copy link
Contributor

Srokap commented Nov 2, 2017

I'm not sure how do you input new data, but it looks like some of mongo documents have very different properties within same collection. It is important to know what to expect in the results form the api user perspective.

I started a branch to add more assertions for results https://github.com/Srokap/SpaceX-API/tree/more_assertions and noticed that ie. dragon capsule and falcon rockets data differs wildly. The launches data has single launch with missing UTC timestamp.

So main question is about approach to take to make api useful for it's users that need to make assumptions about what to expect in results. We could track it in tests, or we could validate data when being put into db. In this use case, making extensive input tools might be not worth the effort, so we might run travis on master on schedule instead (don't remember if Travis allows to run tests on demand).

@jakewmeyer
Copy link
Member

jakewmeyer commented Nov 26, 2017

TODO:

@jakewmeyer
Copy link
Member

I think the capsule data shouldn't be with the other rocket data, so all the rockets can have the same schema. I'll create a new collection and endpoint for capsule data at some point this week 👍

@jakewmeyer
Copy link
Member

The schema changes are live now, all rockets should have exactly the same structure, solving the inconsistency issue. Dragon data is now on its own collection and endpoint as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants