Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core serials differ between launch data and core lookup #70

Closed
waterskier2007 opened this issue Feb 1, 2018 · 7 comments
Closed

Core serials differ between launch data and core lookup #70

waterskier2007 opened this issue Feb 1, 2018 · 7 comments

Comments

@waterskier2007
Copy link
Contributor

waterskier2007 commented Feb 1, 2018

disclaimer: might be the same for capsules

example

https://api.spacexdata.com/v2/launches/latest

The core serial is listed as B1032.2 but if you then hit https://api.spacexdata.com/v2/parts/cores/B1032.2

It's incorrect. The serial is actually B1032

If it makes sense to suffix the serial with a .X for number of flights, that could be a separate field.

@jakewmeyer jakewmeyer self-assigned this Feb 1, 2018
@jakewmeyer
Copy link
Member

Looks like the latest launches core serial was a mistake, I haven't been listing the number of reuses in the core serial, since it would make a unique number each time, making it harder to compare against.

We could add a new field for the number of previous flights of the core for each launch, but the data should already be in the detailed core data.

@waterskier2007
Copy link
Contributor Author

@jakewmeyer ok, just checked and it looks good now. I'll leave the decision about reuse numbers up to you.

@jakewmeyer
Copy link
Member

jakewmeyer commented Feb 3, 2018

I'll go ahead and add it in the core section for each launch, I think it's valuable info to have 👍

Trying to decide on a good name for the field...

@petrosh
Copy link

petrosh commented Feb 9, 2018

flown?

@jakewmeyer
Copy link
Member

Flown sounds more like a boolean value though, instead of an incremental amount. Maybe flights?

@petrosh
Copy link

petrosh commented Feb 9, 2018

flights is great 👍

@jakewmeyer
Copy link
Member

Added the field for past and upcoming launches, slight adjustment from flights to flight for clarity 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants