Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Red circles in latticeView sync mode #51

Closed
mtennekes opened this issue Dec 18, 2016 · 3 comments
Closed

Red circles in latticeView sync mode #51

mtennekes opened this issue Dec 18, 2016 · 3 comments

Comments

@mtennekes
Copy link

I almost got latticeView working in tmap. It really works like charm, thanks!

One small thing: in sync mode, the red "cursor" circles are not only visible when the cursor hovers over another facet (as it is supposed to be), but also when the cursor is outside the facets, or when the cursor hovers over the same facet as the red circle. These red "idle" circles are placed in the center of the map.

This problem only seem to appear with leaflet objects, not with mapview objects, at least in this example:

l1 <- leaflet() %>% addProviderTiles("CartoDB.Positron")
l2 <- leaflet() %>% addProviderTiles("OpenStreetMap")
sync(l1, l2)

image

m1 <- mapview()
m2 <- mapview()
sync(m1, m2)

image

@mtennekes
Copy link
Author

I found out that the same issue occurs with mapview objects. The idle circles are always placed at lan=0 and lon=0.

@tim-salabim
Copy link
Member

Yes, I also noticed this. And you are right, it is always located at 0/0.
This stems, afaik, from the underlying JS plugin and I don't think we can do much about it. I will double-check the plugin side and maybe @timelyportfolio can also confirm this?

@tim-salabim
Copy link
Member

I am closing this here even though this is still not resolved. However, I don't intend to address this before leaflet is upgraded to 1.x which will mean that we need to upgrade the plugin too. If this issue then still persists I will try to look into it again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants