More path functionality #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This iterates an idea that @JanCaha already proposed, but was not merged at the time (#152 (comment)). Specifically, the function is now explicitly limited to Windows and macOS.
This only has effect (and happens while loading the package) if the following conditions are all true: - an option qgisprocess.detect_newer_qgis or env var R_QGISPROCESS_DETECT_NEWER_QGIS is set as TRUE - system is Windows or macOS - two or more QGIS installations are present in their own default path _and_ these paths contain the QGIS version number (typical for the standalone installs) - the qgisprocess cache does not point at the newest version of those QGIS paths If so, the user will be offered the possibility to switch to the newer QGIS version. This is a further addition wrt #187.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
qgis_detect_paths()specifically for Windows and macOS, used as a helper in the next addition. See also Detect paths #152 (comment).qgis_configure(): optionally detect and propose newer QGIS (win/mac)The second addition only has effect (and happens while loading the package) if the following conditions are all true:
qgisprocess.detect_newer_qgisor env varR_QGISPROCESS_DETECT_NEWER_QGISis set as TRUEIf so, the user will be offered the possibility to switch to the newer QGIS version. Still to be tested in a real system.
This is a further addition wrt #187.