Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing test file (#145) #146

Merged
merged 2 commits into from Oct 14, 2021
Merged

add missing test file (#145) #146

merged 2 commits into from Oct 14, 2021

Conversation

paleolimbot
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Oct 10, 2021

Codecov Report

Merging #146 (f1e1a0e) into master (013177e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #146   +/-   ##
=======================================
  Coverage   94.45%   94.45%           
=======================================
  Files          40       40           
  Lines        2814     2814           
=======================================
  Hits         2658     2658           
  Misses        156      156           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 013177e...f1e1a0e. Read the comment docs.

@paleolimbot
Copy link
Collaborator Author

@PikalaxALT Any chance you test this to see if it fixes your issue? You should be able to test using:

remotes::install_github("r-spatial/s2#146")

@paleolimbot
Copy link
Collaborator Author

The latest CI run passes after I made that exact change yesterday: https://github.com/r-spatial/s2/runs/3851860038#step:7:13

Does the code I pasted above work locally for you?

remotes::install_github("r-spatial/s2#146")

@paleolimbot paleolimbot merged commit 316eb28 into master Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants