Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vector class updates #181

Merged
merged 3 commits into from May 31, 2022
Merged

Vector class updates #181

merged 3 commits into from May 31, 2022

Conversation

paleolimbot
Copy link
Collaborator

This PR eliminates the s2_lnglat and s2_point vector classes to use wk's xy() and xyz() with special CRS values. The wk classes are much, much, faster!

Fixes #159.

@codecov-commenter
Copy link

codecov-commenter commented May 30, 2022

Codecov Report

Merging #181 (50180e8) into main (6134c0e) will decrease coverage by 0.04%.
The diff coverage is 94.44%.

@@            Coverage Diff             @@
##             main     #181      +/-   ##
==========================================
- Coverage   93.67%   93.62%   -0.05%     
==========================================
  Files          50       49       -1     
  Lines        3541     3483      -58     
==========================================
- Hits         3317     3261      -56     
+ Misses        224      222       -2     
Impacted Files Coverage Δ
R/vctrs.R 100.00% <ø> (+20.00%) ⬆️
R/s2-lnglat.R 83.33% <81.81%> (-16.67%) ⬇️
R/s2-point.R 92.30% <92.30%> (-7.70%) ⬇️
R/s2-cell.R 100.00% <100.00%> (ø)
R/s2-geography.R 98.30% <100.00%> (ø)
src/s2-lnglat.cpp 100.00% <100.00%> (+3.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6134c0e...50180e8. Read the comment docs.

@paleolimbot paleolimbot merged commit b168197 into main May 31, 2022
@paleolimbot paleolimbot deleted the vctr-classes branch June 1, 2022 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vector class updates
2 participants