Release s2 1.1.2

[paleolimbot]

Prepare for release:

• git pull
• Check current CRAN check results
• Polish NEWS
• devtools::build_readme()
• urlchecker::url_check()
• devtools::check(remote = TRUE, manual = TRUE)
• devtools::check_win_devel()
• rhub::check_for_cran()
• rhub::check(platform = 'ubuntu-rchk')
• rhub::check_with_sanitizers()
• revdepcheck::revdep_check(num_workers = 4)
• Update cran-comments.md
• git push

Submit to CRAN:

• usethis::use_version('patch')
• devtools::submit_cran()
• Approve email

Wait for CRAN...

• Accepted 🎉
• git push
• usethis::use_github_release()
• usethis::use_dev_version()
• git push

[paleolimbot]

There is also

In member function 'std::__atomic_base<_IntTp>::__int_type std::__atomic_base<_IntTp>::fetch_add(__int_type, std::memory_order) [with _ITp = int]',
    inlined from 'void absl::lts_20210324::cord_internal::Refcount::Increment()' at ../src/absl/strings/internal/cord_internal.h:80:21,
    inlined from 'static absl::lts_20210324::cord_internal::CordRep* absl::lts_20210324::cord_internal::CordRep::Ref(absl::lts_20210324::cord_internal::CordRep*)' at ../src/absl/strings/internal/cord_internal.h:526:26,
    inlined from 'absl::lts_20210324::cord_internal::CordRep* absl::lts_20210324::Cord::TakeRep() const &' at absl/strings/cord.cc:677:22,
    inlined from 'void absl::lts_20210324::Cord::AppendImpl(C&&) [with C = const absl::lts_20210324::Cord&]' at absl/strings/cord.cc:722:23:
d:\rtools43\x86_64-w64-mingw32.static.posix\lib\gcc\x86_64-w64-mingw32.static.posix\12.2.0\include\c++\bits\atomic_base.h:618:34: warning: 'unsigned int __atomic_fetch_add_4(volatile void*, unsigned int, int)' writing 4 bytes into a region of size 0 overflows the destination [-Wstringop-overflow=]
  618 |       { return __atomic_fetch_add(&_M_i, __i, int(__m)); }
      |                ~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~

on Windows on the check page!

[edzer]

I didn't get that, but get these checks on win-builder, with 2 other warnings. This is with 1.1.1.9000 - are we looking at different branches?

[paleolimbot]

I get https://win-builder.r-project.org/3GeVJIR8AaTz/00check.log on Winbuilder (just the warning that's reported on the check pag)...I'm on 'main':

deweydunnington@Deweys-MacBook-Air-2 s2 % git status      
On branch main
Your branch is up to date with 'origin/main'.

nothing to commit, working tree clean
deweydunnington@Deweys-MacBook-Air-2 s2 % git log -n 1
commit c317e8e9b9cd58eaf3e83310df6507b51b49d743 (HEAD -> main, origin/main, origin/HEAD)
Author: Dewey Dunnington <dewey@fishandwhistle.net>
Date:   Tue Dec 27 14:01:39 2022 -0400

    Add cdstdint include to Abseil header (#210)
    
    * add cdstdint include to abseil header
    
    * NEWS bullet

[edzer]

Sorry, we were looking at the same thing. This seems an absl + new gcc version issue that might get solved by upgrading absl, right? If so, shall I submit promising we will look into that for the next submission?

[paleolimbot]

Since CRAN submissions are still closed, let me give it a shot tonight after the kids are asleep to see if I can silence the warning. Upgrading absl isn't trivial and it should really be done alongside upgrading s2 since there's a nice new version out that has a spherical buffer (among other fixes).

[edzer]

that has a spherical buffer (among other fixes).

[drooling emoji]

[paleolimbot]

I couldn't fix that particular error without changing code I don't understand; however, I did the PR to update absl (#213, which wasn't as bad as I though it would be, at least so far).

[paleolimbot]

This is all good from my point of view! There may be some hiccups with the updated abseil to sort out because Abseil is complicated and CRAN's environments are hard to replicate; however, I think that's a better solution than attempting to patch the current CRAN error with the old version of Abseil.

[edzer]

Great - submitted!

[edzer]

Windows passes; we still have one warning on the debian CRAN checks, see here. Is that something that can be resolved?

[paleolimbot]

Totally! Now that I'm looking for it, I see that error on clang/MacOS too.

[paleolimbot]

Should probably wait for the CI to pass, but ee86989 should do it.

[edzer]

I agree, that should do it!

[edzer]

from CRAN:

Thanks, reverse dependency checks have been triggered, but there are a few hundred warnings about


../src/absl/base/config.h:341:1: warning: multi-line comment [-Wcomment]
  341 | // #if (defined(__clang__) && !defined(_WIN32)) || \
      | ^

../src/absl/base/internal/raw_logging.h:47:3: warning: multi-line comment [-Wcomment]
   47 |   // do {                   \
      |   ^

which should be fixed for future submissions.

[edzer]

... on CRAN - fantastic!