gcc13 issue

[edzer]

From CRAN:

Dear maintainer,

Please see the problems shown on
[<https://cran.r-project.org/web/checks/check_results_s2.html>](https://cran.r-project.org/web/checks/check_results_s2.html).

Please correct before 2023-04-12 to safely retain your package on CRAN.

Do remember to look at the 'Additional issues'.

The CRAN Team

[paleolimbot]

Bit of a trick to find the actual error but maybe:

../src/absl/strings/cord.h:1182:9: warning: writing 16 bytes into a region of size 3 [-Wstringop-overflow=]
 1182 |   memcpy(result->Data(), data_.as_chars(), sizeof(data_));
      |         ^
In file included from ../src/absl/strings/cord_analysis.h:22,
                 from ../src/absl/strings/cord.h:82:
../src/absl/strings/internal/cord_internal.h:242:11: note: destination object 'absl::lts_20220623::cord_internal::CordRep::storage' of size 3
  242 |   uint8_t storage[3];
      |           ^~~~~~~
../src/absl/strings/cord.h: In member function 'void absl::lts_20220623::Cord::InlineRep::PrependTreeToInlined(absl::lts_20220623::Cord::CordRep*, absl::lts_20220623::Cord::MethodIdentifier)':
../src/absl/strings/cord.h:1182:9: warning: writing 16 bytes into a region of size 3 [-Wstringop-overflow=]
 1182 |   memcpy(result->Data(), data_.as_chars(), sizeof(data_));
      |         ^
../src/absl/strings/internal/cord_internal.h:242:11: note: destination object 'absl::lts_20220623::cord_internal::CordRep::storage' of size 3
  242 |   uint8_t storage[3];
      |           ^~~~~~~

[edzer]

We have a final reminder until 2023-04-26. Did you have a chance to look into this one?

[edzer]

The check results now summarize the problem to

* checking whether package ‘s2’ can be installed ... [21m/15m] WARNING
Found the following significant warnings:
  ../src/absl/strings/cord.h:1182:9: warning: writing 16 bytes into a region of size 3 [-Wstringop-overflow=]
See ‘/data/gannet/ripley/R/packages/tests-gcc13/s2.Rcheck/00install.out’ for details.

[edzer]

It seems upstream no longer uses memcpy here:
https://github.com/abseil/abseil-cpp/blob/master/absl/strings/cord.h#L1148
so maybe update absl?

[paleolimbot]

Sorry, I forgot. I will take a look today (latest: tomorrow).

Updating abseil is a pain so if possible I'd like to patch. I believe that S2 only uses the Abseil strings module for logging and import/export of the text format that it invented (neither of which we use), so it's not a critical piece as far as I know.

[edzer]

Did you get around looking into this one?

[paleolimbot]

Both kids have RSV 😬 (but 4/26 shouldn't be a problem!)

[paleolimbot]

(both kids currently asleep 👍 )