-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make git diff prettier #35
Comments
Depends on #46 |
Took a first cut at this. Here's a sample for some feedback: @craffel I think you said this depends on #46 because we want the diff tool to give some idea of what intermediate changes were applied between two versions of a checkpoint (e.g., between commit A and commit B there were 2 sparse updates and one dense update). As per my current understanding this will not be possible with the information that git provides external diff tools. The interface git enforces for diff tools is that they take the following parameters: |
I think with the way I setup the parameter updates on the FS we can actually figure out the updates applied. Basically each update to a parameter is stored in a sub-dir that is named with the hash of the parameters for that update. So if we follow to metadata backpointers from I think this is dependent on the diff direction through? Like we need the on-disk A demo FS dir can be found here https://github.com/r-three/git-theta/blob/3e8566a83b6ef1e5cc5a24dc41ad7e0d73b8a0d3/git_theta/updates/base.py |
Yeah, just took a look at the updates PR and this seems feasible for diff-ing versions that do not have a dense update between them (since the updates folder is purged upon a dense update). I guess I'll wait on implementing this feature until after #92 gets merged. |
Finished in #207 |
Involves making a custom difftool
The text was updated successfully, but these errors were encountered: