Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meet a error when run release-file-system-image.yml action #19

Open
shalom-lab opened this issue Apr 26, 2024 · 3 comments
Open

Meet a error when run release-file-system-image.yml action #19

shalom-lab opened this issue Apr 26, 2024 · 3 comments

Comments

@shalom-lab
Copy link

I make a repo according to the tutorial https://r-wasm.github.io/rwasm/articles/github-actions.html. The content of packages file are:

cli
dplyr
readr
ggplot2

But release-file-system-image.yml action run failed with the following error: what's wrong with it?
https://github.com/shalom-lab/build-wasm-pkgs/actions/runs/8843585286/job/24284009800
微信截图_20240426174725
微信截图_20240426174743

@shalom-lab shalom-lab changed the title Meet a error when Meet a error when run release-file-system-image.yml action Apr 26, 2024
@georgestagg
Copy link
Member

georgestagg commented Apr 26, 2024

Hi,

The documentation on the {rwasm} package is a little out of date and needs to be rewritten. Sorry about that.

You have both deploy.yml and release-file-system-image.yml in your repository. They do slightly different things and you should only need to use one of them, depending on what you plan to do.


If you are intending to build an R package repository, this is already working and building an R Wasm repository from your list of packages. You can see that by running:

webr::install("cli", "https://shalom-lab.github.io/build-wasm-pkgs/")

in the webR app or in Shinylive and seeing that it is successful. The workflow file deploy.yml is handling that, and the GHA run details are here: https://github.com/shalom-lab/build-wasm-pkgs/actions/runs/8843819904


If you are planning on building a custom R package to be compiled for Wasm, then the file release-file-system-image.yml is designed to be added to an R package source repository and build an R package for Wasm on release. In this case, you do not have an R package yet in your repository (i.e there is no DESCRIPTION file) and so there is no R package to build and attach to your GitHub releases.

Once you create an R package in this repository, the release-file-system-image.yml workflow should begin to work.

@shalom-lab
Copy link
Author

Thanks for your quick reply. I have already understood the function of deploy.yml GHA and it works. I thought I need using the
release-file-system-image.yml but I am confused now about the function of release-file-system-image.yml GHA .

I want to put all wasm version packages in the package list into library.data' and 'library.js.metadata so I can mount this file with webr::mount(). Just like this tutorial says https://r-wasm.github.io/rwasm/articles/github-actions.html#using-an-r-package-library-image.

I am not sure whether I should use release-file-system-image.yml GHA or I need to manually build an R package library according to Building an R package library.

@georgestagg
Copy link
Member

Please ignore the tutorial at https://r-wasm.github.io/rwasm/articles/github-actions.html#using-an-r-package-library-image. It is out of date and incorrect. I have opened an issue about it here #21.

For now, you should use deploy.yml and install your packages with e.g. webr::install("cli", "https://shalom-lab.github.io/build-wasm-pkgs/"). You can ignore release-file-system-image.yml for your use case.

There are more detailed community-written instructions for the workflow here: https://github.com/coatless-tutorials/webr-org-gh-action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants