Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panes should have labels/titles #267

Closed
hturner opened this issue Sep 11, 2023 · 2 comments
Closed

Panes should have labels/titles #267

hturner opened this issue Sep 11, 2023 · 2 comments

Comments

@hturner
Copy link

hturner commented Sep 11, 2023

Comment from @ajrgodfrey

Apart from the terminal input window, there are no labels/titles explaining what the different panes are.

@ajrgodfrey
Copy link

ajrgodfrey commented Sep 11, 2023 via email

@georgestagg
Copy link
Member

As of 7df7964 the four main panes are labelled with role='region' and e.g. aria-label="Editor Pane".

I've also reworked the labelling of elements throughout the page, including updating the tabs at the top of the Editor Pane so that each open file tab is labelled with its filename. The editor should now also update its aria-labelledby attribute to point at the tab corresponding to the currently open file.

Hopefully, this makes the app easier to navigate via screen-reader, but do let me know if there are any other significant elements I've missed that require labelling.

(It will take a few hours for the webR website to update, but the changes should be available by tomorrow.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants