Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable tabbing to Run button #269

Closed
hturner opened this issue Sep 11, 2023 · 2 comments
Closed

Enable tabbing to Run button #269

hturner opened this issue Sep 11, 2023 · 2 comments

Comments

@hturner
Copy link

hturner commented Sep 11, 2023

comment from @ajrgodfrey

The run button should come after the script window so that a screen reader can tab from the script window directly to the run button. Currently, tab does not exit the script window: you can arrow out but not tab out and tab is the more usual way to navigate.

@ajrgodfrey
Copy link

ajrgodfrey commented Sep 11, 2023 via email

@georgestagg
Copy link
Member

In 7df7964 I tweaked the order of HTML elements so that the Editor component comes just before the Run button when using Tab navigation.


There is a tricky issue here in that the Editor component has been configured so that it captures Tab and Shift-Tab for functionality relating to the indenting of code.

However, there is an escape hatch. If you press the Escape key first, and then the Tab key immediately after, the focus will be moved to the next element, as normal. Similarly for Escape and then Shift-Tab.

I have added a paragraph element to the page, hidden from sighted users, that explains this unexpected functionality. The element has then been linked to the Editor component through its aria-describedby attribute.

As with the other changes, the webR website will take a little while to update, but the changes should be available by tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants