Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working if trashemail address is used in BCC field #15

Closed
dcRUSTy opened this issue May 31, 2020 · 4 comments
Closed

Not working if trashemail address is used in BCC field #15

dcRUSTy opened this issue May 31, 2020 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed wontfix This will not be worked on

Comments

@dcRUSTy
Copy link

dcRUSTy commented May 31, 2020

Compose a new email with trashemail address in BCC field.
Expected - Should be delivered on telegram.
Actual - Not delivered on telegram.
Reason - SMTP Alias?

@rosehgal
Copy link
Owner

I was to complete this flow soon. Thanks for testing and point this out to keep track of it. Actually the reason is not SMTP alias but the way I am parsing the message, I have not included target as cc or bcc. I will work on this quickly.

@rosehgal rosehgal added bug Something isn't working enhancement New feature or request good first issue Good for newcomers and removed bug Something isn't working labels May 31, 2020
@rosehgal
Copy link
Owner

rosehgal commented Jun 1, 2020

This bug is due to https://github.com/r0hi7/Trashemail/blob/6819a7648f917c8b428208560772929d9f6a2d95/src/main/java/io/github/trashemail/Telegram/ForwardMailsToTelegram.java#L25
I missed this out. Actually the mail has to be sent to all the recipients. Try to make this a set instead of the list.

@dcRUSTy
Copy link
Author

dcRUSTy commented Jun 1, 2020

https://docs.oracle.com/javaee/5/api/javax/mail/Message.html#getRecipients(javax.mail.Message.RecipientType) I think it is very possible for email to have TO, CC and BCC field empty I have seen in several SPAM emails and also documentation suggests same "This method returns null if none of the recipient headers are present in this message" I also tried sending email from yahoo to gmail with only BCC field set and observed the BCC field is indeed missing when email was opened on gmail. Not 200% sure but i think it is a possibility. I was referring to this possibility in first comment

@rosehgal rosehgal added wontfix This will not be worked on help wanted Extra attention is needed labels Jun 19, 2020
@rosehgal
Copy link
Owner

rosehgal commented Jun 19, 2020

I tried to send an email with bcc in it but the java mail parsing library is showing email address in BCC as undisclosed email. It will become difficult for me to get the target email address from that. I am marking this issue closed for now and marking it wontfix. In case you feel you have better suggestion and an alternative approach to parsing, you reopen this with PR :)

Thanks again @dcRUSTy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants