Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message parsing is not working as expected. #25

Closed
rosehgal opened this issue Jun 5, 2020 · 3 comments
Closed

Message parsing is not working as expected. #25

rosehgal opened this issue Jun 5, 2020 · 3 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@rosehgal
Copy link
Owner

rosehgal commented Jun 5, 2020

Describe the bug
Message parsing is not working as expected. If you send a very basic HTML mail from any mail service. Following parameters a coming out to be true.

MailParser    : Is plain content true
MailParser    : Is HTML content true
MailParser    : Is multipart true
MailParser    : Is plain content Empty false

Due to which, this statement is never reached. https://github.com/r0hi7/Trashemail/blob/b67de8bfface2386071b32b9a9930d90a77d8b20/src/main/java/io/github/trashemail/utils/MailParser.java#L39
Because this is evaluated to false: https://github.com/r0hi7/Trashemail/blob/b67de8bfface2386071b32b9a9930d90a77d8b20/src/main/java/io/github/trashemail/utils/MailParser.java#L38

To Reproduce
Steps to reproduce the behavior:

  1. Send an HTML mail from good with the following content.
**Bold text**
_Italic_

Expected behavior
Since this is multipart mail, the HTML field should be processed. And HTML message should be recorded.

@rosehgal
Copy link
Owner Author

rosehgal commented Jun 5, 2020

@nishitm, I am checking on this. But since, you merged the PR for this, can you cross verify this issue?

@rosehgal rosehgal added bug Something isn't working good first issue Good for newcomers labels Jun 5, 2020
@rosehgal
Copy link
Owner Author

rosehgal commented Jun 5, 2020

The RC of this bug was that it was not ever checking for multipart data.

@rosehgal
Copy link
Owner Author

rosehgal commented Jun 5, 2020

Fixed in #26

@rosehgal rosehgal closed this as completed Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant