Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

response-type not working (missing key in function params) #63

Closed
timknip opened this issue Jun 7, 2015 · 2 comments
Closed

response-type not working (missing key in function params) #63

timknip opened this issue Jun 7, 2015 · 2 comments

Comments

@timknip
Copy link

timknip commented Jun 7, 2015

Specifying a :response-type doesn't work because the key is not specified here:
https://github.com/r0man/cljs-http/blob/master/src/cljs_http/core.cljs#L73

Adding it fixes it.

ie:
[{:keys [request-method headers body with-credentials? cancel response-type] :as request}]
@r0man
Copy link
Owner

r0man commented Jun 7, 2015

@timknip The whole request is passed to build-xhr and destructured there.
Are you sure this is the problem? Ping @skrat

@timknip
Copy link
Author

timknip commented Jun 7, 2015

@r0man You're right,
Sorry, my bad. Damn typo :S
Closing it.

@timknip timknip closed this as completed Jun 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@r0man @timknip