Stop freezing main thread #638

Ksengine · 2020-11-04T17:12:55Z

stop freezing main thread

winforms Edge(supported, tested)
winforms CEF (supported, not tested)
winforms IE (supported, not tested)
gtk(supported, tested)
qt(supported, tested on linux only)
cocoa(not supported)

so,

test IE
test CEF
test qt on mac
develop cocoa

other developers are welcomed

automatically set webpage title as window title if user want

Automatically set title of webpage as window title

Automatically set icon of webpage as window icon

auto icon

update

- multiprocessing added - fixed threading - added two keyword arguments to start method - block(default : True) - daemon(default : True)(works if block is False) ex(block):- ```python import webview w = webview.create_window("ssss","https://www.google.com") join = webview.start(block=False) # set block option to False( default:True ) print('free main thread') # Some code print('blocked main thread') join() # join gui loop to main thread print('free main thread') # this line works after gui loop ended ``` ex(block without join):- ```python import webview w = webview.create_window("ssss","https://www.google.com") join = webview.start(block=False) # set block option to False( default:True ) print('free main thread') # Some code # program exits when no any code run and gui loop ended ``` ex(daemon):- ```python import webview w = webview.create_window("ssss","https://www.google.com") join = webview.start(block=False, daemon=False) # set daemon option to False( default:True ) print('free main thread') # Some code # gui loop stops and exit program ```

Stop freezing Main thread

@r0x0r

`real_start` changed to `_start` according to review of @r0x0r

give a try

update

stop freezing main thread using threading or multiprocessing - remove multiprocessing arg of window class

- remove multiprocessing arg of _initialize

gtk only on linux so used multiprocessing in `fork` method

returns thread to user

- modified current thread checker in create_window - start returns the process if multiprocessing else None

- stop run app.exec_ if multiprocessing is True - create fake Process class - return fake process

sorry, i cant test this on mac so it raises RuntimeError when multiprocessing

forgot ti import _multiprocessing

Update stale.yml

Ksengine · 2020-12-24T15:54:13Z

@r0x0r It's ok. MacOS is working and tested(on github actions).

github-actions · 2021-01-24T03:00:40Z

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Ksengine · 2021-01-25T03:22:50Z

Hi @r0x0r can you merge this.

r0x0r · 2021-01-25T15:59:44Z

macOS no workie


[pywebview] Using Cocoa
Traceback (most recent call last):
  File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/Users/roman/.vscode/extensions/ms-python.python-2021.1.502429796/pythonFiles/lib/python/debugpy/__main__.py", line 45, in <module>
    cli.main()
  File "/Users/roman/.vscode/extensions/ms-python.python-2021.1.502429796/pythonFiles/lib/python/debugpy/../debugpy/server/cli.py", line 444, in main
    run()
  File "/Users/roman/.vscode/extensions/ms-python.python-2021.1.502429796/pythonFiles/lib/python/debugpy/../debugpy/server/cli.py", line 285, in run_file
    runpy.run_path(target_as_str, run_name=compat.force_str("__main__"))
  File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/runpy.py", line 263, in run_path
    pkg_name=pkg_name, script_name=fname)
  File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/runpy.py", line 96, in _run_module_code
    mod_name, mod_spec, pkg_name, script_name)
  File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/Users/roman/Code/pywebview/examples/noblock.py", line 11, in <module>
    webview.start(block=False)
  File "/Users/roman/Code/pywebview/webview/__init__.py", line 127, in start
    return guilib.create_window(windows[0])
  File "/Users/roman/Code/pywebview/webview/platforms/mp_cocoa.py", line 74, in create_window
    windows[window.uid] = window
TypeError: list indices must be integers or slices, not str
Exception in thread Thread-7:
Traceback (most recent call last):
  File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/threading.py", line 916, in _bootstrap_inner
    self.run()
  File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/threading.py", line 864, in run
    self._target(*self._args, **self._kwargs)
  File "/Users/roman/Code/pywebview/webview/platforms/mp_cocoa.py", line 64, in event_loop
    uid, event = event_queue.get()
  File "<string>", line 2, in get
  File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/multiprocessing/managers.py", line 757, in _callmethod
    kind, result = conn.recv()
  File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/multiprocessing/connection.py", line 250, in recv
    buf = self._recv_bytes()
  File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/multiprocessing/connection.py", line 407, in _recv_bytes
    buf = self._recv(4)
  File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/multiprocessing/connection.py", line 383, in _recv
    raise EOFError
EOFError

github-actions · 2021-02-26T02:06:49Z

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Ksengine · 2021-02-26T02:10:27Z

Not stale

github-actions · 2021-03-29T02:29:10Z

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Ksengine · 2021-03-30T02:18:26Z

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

not stale

github-actions · 2021-04-29T02:26:57Z

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Ksengine · 2021-04-29T14:13:35Z

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Not stale

github-actions · 2021-05-30T04:30:45Z

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Ksengine · 2021-05-30T15:53:06Z

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Not stale

github-actions · 2021-07-01T02:13:42Z

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions · 2021-07-07T02:10:47Z

The message to post on the pr when closing it. If none provided, will not comment when closing a pull requests.

Ksengine added 30 commits October 20, 2020 07:13

auto title

402a6b2

automatically set webpage title as window title if user want

auto title

4f532a2

auto title

e8debf8

auto title

2a3b657

Automatically set title of webpage as window title

auto icon

a18fc74

Automatically set icon of webpage as window icon

auto icon

d83f4f2

Automatically set icon of webpage as window icon

auto icon

e9573f8

Automatically set icon of webpage as window icon

auto icon

e4efec1

Merge pull request #1 from Ksengine/Ksengine-patch-qt

5ccb75f

auto icon

Merge pull request #2 from r0x0r/master

65b5d82

update

Merge pull request #3 from Ksengine/multiprocessing-2

0de1c88

Stop freezing Main thread

update from originwl

14d2d95

update from originwl

5e47ee4

update from original

36415fa

rename method

dd750e4

`real_start` changed to `_start` according to review of @r0x0r

add multiprocessing to winforms

9a2d809

give a try

Merge pull request #4 from r0x0r/master

1d96b09

update

Update __init__.py

a04d792

stop freezing main thread

f473d49

stop freezing main thread using threading or multiprocessing - remove multiprocessing arg of window class

Update window.py

77a0963

remove arg

48b0978

- remove multiprocessing arg of _initialize

stop freezing main thread

c4acd6c

gtk only on linux so used multiprocessing in `fork` method

stop freezing main thread

046e4d6

returns thread to user

stop freezing main thread

cbdd1dd

- modified current thread checker in create_window - start returns the process if multiprocessing else None

stop freezing main thread

8d9563a

- stop run app.exec_ if multiprocessing is True - create fake Process class - return fake process

stop freezing main thread

90a5814

sorry, i cant test this on mac so it raises RuntimeError when multiprocessing

forgot

2b8db1b

forgot ti import _multiprocessing

Merge pull request #5 from r0x0r/master

11a1404

Update stale.yml

rename windows api to python like

97d83db

github-actions bot added the stale label Jan 24, 2021

Merge branch 'master' into master

2377657

github-actions bot removed the stale label Jan 26, 2021

Update mp_cocoa.py

d1d6d97

github-actions bot added the stale label Feb 26, 2021

github-actions bot removed the stale label Feb 27, 2021

github-actions bot added the stale label Mar 29, 2021

Merge branch 'master' into master

2d97488

github-actions bot removed the stale label Mar 30, 2021

github-actions bot added the stale label Apr 29, 2021

github-actions bot removed the stale label Apr 30, 2021

Merge branch 'master' into master

c734d5a

github-actions bot added the stale label May 30, 2021

github-actions bot removed the stale label May 31, 2021

github-actions bot added the stale label Jul 1, 2021

github-actions bot closed this Jul 7, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Stop freezing main thread #638

Stop freezing main thread #638

Ksengine commented Nov 4, 2020

Ksengine commented Dec 24, 2020

github-actions bot commented Jan 24, 2021

Ksengine commented Jan 25, 2021

r0x0r commented Jan 25, 2021

github-actions bot commented Feb 26, 2021

Ksengine commented Feb 26, 2021

github-actions bot commented Mar 29, 2021

Ksengine commented Mar 30, 2021

github-actions bot commented Apr 29, 2021

Ksengine commented Apr 29, 2021

github-actions bot commented May 30, 2021

Ksengine commented May 30, 2021

github-actions bot commented Jul 1, 2021

github-actions bot commented Jul 7, 2021

Stop freezing main thread #638

Stop freezing main thread #638

Conversation

Ksengine commented Nov 4, 2020

Ksengine commented Dec 24, 2020

github-actions bot commented Jan 24, 2021

Ksengine commented Jan 25, 2021

r0x0r commented Jan 25, 2021

github-actions bot commented Feb 26, 2021

Ksengine commented Feb 26, 2021

github-actions bot commented Mar 29, 2021

Ksengine commented Mar 30, 2021

github-actions bot commented Apr 29, 2021

Ksengine commented Apr 29, 2021

github-actions bot commented May 30, 2021

Ksengine commented May 30, 2021

github-actions bot commented Jul 1, 2021

github-actions bot commented Jul 7, 2021