Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edge support for Windows #243

Closed
r0x0r opened this issue Aug 13, 2018 · 8 comments
Closed

Edge support for Windows #243

r0x0r opened this issue Aug 13, 2018 · 8 comments

Comments

@r0x0r
Copy link
Owner

r0x0r commented Aug 13, 2018

Microsoft has finally added support for hosting UWA controls in Windows Forms / WPF apps. Will be most appreciated if someone can test drive this.

https://docs.microsoft.com/en-us/windows/uwp/xaml-platform/xaml-host-controls

@r0x0r
Copy link
Owner Author

r0x0r commented Aug 13, 2018

The above docs are not clear on this, but apparently this requires .NET Core 3, which is not released yet.

@shivaprsd
Copy link
Collaborator

This is good news.. Winds of change 🙂

@austinorr
Copy link

@shivaprsdv @r0x0r more winds than expected? At first glance this seems like really good news.

@r0x0r
Copy link
Owner Author

r0x0r commented Dec 7, 2018 via email

@shivaprsd
Copy link
Collaborator

Well well.. First GitHub, now Chromium, are you serious, Microsoft? 😄
This means we can get away without #15 as well. 🤷‍♂️

@r0x0r
Copy link
Owner Author

r0x0r commented May 28, 2019

Current progress is in the edge-support branch. The basic functionality is there (including auto-detection of Edge support), but JS support is missing.

The main hurdle is that InvokeScriptAsync crashes the program for content loaded with NavigateToString. The bug is described here. It was apparently fixed, but the fix is not present in 5.1.1. Tried installing the preview version of WebView 6.0, but for some reason it did not work.
There are a couple of solutions described in the issue. All involve using something else than NavigateToString. Anyhow the Edge is no different to other implementations - finding odd solutions for quirky bugs.

The architecture will need a major refactor at some point, but won't happen before pywebview 3 release.

@r0x0r
Copy link
Owner Author

r0x0r commented Jun 14, 2019

WebViewControl is buggy af.

In addition to the bug above file:// URLs are not supported and there is a bug related to crashing the program after closing a window via window.close. This makes the test runner crash.
Anyhow I made it work in a more or less adequate manner. I will not spend any more time polishing it at this point and will release 3.0 using the current version.

Known issues are documented here

@r0x0r r0x0r mentioned this issue Jun 24, 2019
@r0x0r
Copy link
Owner Author

r0x0r commented Jun 24, 2019

PR is here
Closing this issue now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants