Confirm on close

[michel-cf]

I'd like use this in my project, but one of my functional requirements is a confirm dialog on close.

Is this something that can be easily added?

[r0x0r]

Yes, it is definitely doable. Thanks for the suggestion.
I will implement it sometime in the future. Help is more than welcome.

[r0x0r]

Bounty

[AstraLuma]

Could you make this a callback of some sort? Or some other way to plug in application logic?

[r0x0r]

How would you envision a callback?
I can think of two basic confirmation types: Are you sure you want to exit (Yes, No) and You have unsaved changes (Save, Don't Save, Cancel). The first one certainly does not need a callback, but the second one, could use one for the Save functionality. Localization would be nice too (currently all the strings are hardcoded in English).

[AstraLuma]

Well, there's also the problem of how to display such a dialog. If the application has other dialogs/prompts, it should be displayed in the same style--which is probably HTML. (Although Tkinter does have some APIs for native system dialogs.)

There's also other kinds of "do you want to exit" prompts: "Do you want to disconnect?", "Can't exit now; please wait for outstanding jobs to finish.", other variations of "unsaved data".

The simplest thing to do would probably be to add a keyword argument exitcallback. Returns a bool: True to cancel, False (or None) to exit. It also wouldn't be unreasonable to add a module-level function to set it.

[AstraLuma]

FYI, I wrote a wrapper that has an instance method .onclose() meant to be used as a decorator.

[r0x0r]

I have started implementing a confirmation dialog here https://github.com/r0x0r/pywebview/tree/confirmation-dialog

[simplynail]

Great news! just started to use pywebview and thought it would be great to have a confirmation dialog. And here it is, being implemented :)

[r0x0r]

Simple OK/Cancel confirmation dialogs are implemented on Windows and OSX. Linux is on the way.

[r0x0r]

All platforms support now OK/Cancel confirmation dialog. The confirmation-dialog branch is merged with master.

[shivaprsd]

Why is this issue still open?

[r0x0r]

A three way confirmation dialog (eg. Save, don't save, cancel) is still missing.

[r0x0r]

Let's close this one and reopen if there is a concrete need for a three-way dialog

[NiceneNerd]

So, at present, is there a way or workaround to have something like a save confirmation on close?

[r0x0r]

You can set window.confirm_close to True if document needs saving. You cannot set a custom dialog text this way though.