Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sinatra 3/4 compatibility? (Proposed gemspec change) #74

Open
voretaq7 opened this issue May 20, 2024 · 0 comments
Open

Sinatra 3/4 compatibility? (Proposed gemspec change) #74

voretaq7 opened this issue May 20, 2024 · 0 comments

Comments

@voretaq7
Copy link

Looks like the gemspec for sinatra-r18n may be unnecessarily restrictive as '>= 1.3', '< 3'
This prevents the gem from being used in Sinatra 3 or Sinatra 4 applications.

sinatra-r18n appears to function correctly under noth Sinatra 3 and Sinatra 4 if I remove the <3 from the specification.
At least our internal tests are passing and strings are getting properly translated - if it's broken it's breaking outside my use case.

If there isn't a known issue or a deprecation of sinatra-r18n with later versions of Sinatra my life would be easier if the <3 restriction were loosened upstream. :-)


Steps to Reproduce

Simply require sinatra/r18n with Sinatra 3.x or 4.x as your default Sinatra version.

Expected Behavior

sinatra-r18n should load and operate normally.

Actual Behavior

Gem::ConflictError will be raised because of the sinatra-r18n gemspec requiring sinatra < 3.

Fix/Workaround

From our admittedly limited testing It appears safe to simply change the sinatra-r18n gemspec to require sinatra '>=1.3', '< 5' (maintaining a major version cap in case future major releases of Sinatra change functionality sinatra-r18n relies on).

Other Information

ruby -v:

ruby 3.2.4 (2024-04-23 revision af471c0e01) [amd64-freebsd14]

Relevant gems (off my test system):

rack (3.0.11)
sinatra (4.0.0)
sinatra-contrib (4.0.0)
sinatra-r18n (5.0.2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant