Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace ZeroInit with bytemuck::Zeroable #14

Closed
yvt opened this issue Nov 19, 2022 · 1 comment
Closed

Replace ZeroInit with bytemuck::Zeroable #14

yvt opened this issue Nov 19, 2022 · 1 comment
Assignees

Comments

@yvt
Copy link
Member

yvt commented Nov 19, 2022

r3_core::utils::ZeroInit should be replaced by bytemuck::Zeroable. The latter is derivable (which helps us remove some unsafe impls) and has a better Rust ecosystem compatibility.

Zeroable is missing the following implementations:

@yvt yvt self-assigned this Nov 20, 2022
@yvt
Copy link
Member Author

yvt commented Nov 20, 2022

Merged in b6de1c0

@yvt yvt closed this as completed Nov 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant