Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More Validation in .validate_attributes #15

Open
jonthegeek opened this issue Oct 15, 2022 · 1 comment
Open

More Validation in .validate_attributes #15

jonthegeek opened this issue Oct 15, 2022 · 1 comment
Labels
good first issue ❤️ good issue for first-time contributors upkeep maintenance, infrastructure, and similar

Comments

@jonthegeek
Copy link
Contributor

Check each value to make sure it's NULL or legal.
@jonthegeek jonthegeek added upkeep maintenance, infrastructure, and similar good first issue ❤️ good issue for first-time contributors labels Oct 15, 2022
@jonthegeek
Copy link
Contributor Author

I partially implemented this, but, for example, domain and path really should be checked to make sure they have the expected form (when they aren't NULL). Super low priority but checking this for rules/guidelines should be relatively straightforward. Ideally use grep or something from htmltools or utils for the validation (ie, I don't want to import stringr, I don't think).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue ❤️ good issue for first-time contributors upkeep maintenance, infrastructure, and similar
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jonthegeek