Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IManagerEventHandler not firing events #48

Closed
alreay opened this issue Nov 22, 2016 · 2 comments
Closed

IManagerEventHandler not firing events #48

alreay opened this issue Nov 22, 2016 · 2 comments

Comments

@alreay
Copy link

alreay commented Nov 22, 2016

Hi all,
I've wrapped cAudio with a singleton manager that uses the audiomanager with the threaded update feature.

The interface that I inherit from IManagerEventHandler.h includes the virtual functions that can be overridden like "onUpdate()" but cAudioManager.cpp never actually fires the events although it does handle them all.

The fix is very simple, just one line, and I'll be happy to create a pull request from what I've modified to make it work in my case. However, I'm curious to hear if there's something obvious that I've missed with how this is supposed to work or whether it's always been left unimplemented for some reason.

In case you're interested, my wrapper has a music playlist which needs to be advanced at the end of a song and does things like fade outs when notified by the game engine thread. That's why I need to get the update event firing.

Cheers and thanks for cAudio!

@r4stl1n
Copy link
Owner

r4stl1n commented Nov 23, 2016

I haven't heard about the IManagerEventHandler not firing events id love to see the pull request and figure out what is causing the issue.

@r4stl1n
Copy link
Owner

r4stl1n commented Dec 4, 2016

Looks like you took care of it. Merged in and thanks for finding it.

@r4stl1n r4stl1n closed this as completed Dec 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants