Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

why is_end_of_frames can detection the end frame in test phase? #15

Closed
wangjunchao1118 opened this issue May 21, 2018 · 4 comments
Closed
Labels

Comments

@wangjunchao1118
Copy link

thanks for your code.
I have a question about the tacotron_pytorch/tacotron.py line 274. why output.data <= 0.2 is the end frame in test phase. if i use this funtion, i only can decode 2 step in test time.

def is_end_of_frames(output, eps=0.2):
return (output.data <= eps).all()

@r9y9
Copy link
Owner

r9y9 commented May 21, 2018

This is the heuristic I found from my experiments. It may not work for you depending on your experimental settings. If it does not work then you can try your own method.

@PetrochukM
Copy link

You can train a scalar on your test data to fit this parameter!

@wangjunchao1118
Copy link
Author

thanks for your reply.
I use blizzard 2011 nancy data to train tacotron. In my test , i can't find a good eps value for my test sentence. so when i decode a sentence , i decode T_encoder times in test phase. it seems work well.

@stale
Copy link

stale bot commented May 30, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label May 30, 2019
@stale stale bot closed this as completed Jun 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants