Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_eurostat folder handling #226

Closed
pitkant opened this issue Sep 14, 2021 · 3 comments · Fixed by #271
Closed

get_eurostat folder handling #226

pitkant opened this issue Sep 14, 2021 · 3 comments · Fixed by #271
Assignees

Comments

@pitkant
Copy link
Member

pitkant commented Sep 14, 2021

Currently search_eurostat can retrieve the following items: 'dataset', 'folder', 'table' (or 'all' of them). get_eurostat function can download datasets and tables but not folders.

This has led to some confusion whether eurostat package should be able to handle folders as well, by downloading all datasets in a given folder. Another possible enhancement is make eurostat handle folder and dataset hierarchies.

@pitkant pitkant self-assigned this Sep 14, 2021
@antagomir
Copy link
Member

In principle, extending the capabilities to folders would sound good but this has to be balanced with the cost/risk-benefit ratio. Wondering how common use case this would be. We can also leave it for later unless there is a pressing need.

Documentation could be clarified?

@pitkant
Copy link
Member Author

pitkant commented Sep 14, 2021

Yes, clarifying documentation would be the easiest fix here

Partly related to #86 (downloading whole migr_asy folder instead of grepping folders that contain 'migr_asy*' or 'migr_*')

@pitkant pitkant added this to Done in eurostat 4.0.0 Sep 30, 2021
@pitkant pitkant moved this from Done to To do in eurostat 4.0.0 Sep 30, 2021
@pitkant pitkant moved this from To do to In progress in eurostat 4.0.0 Sep 1, 2023
@pitkant pitkant linked a pull request Sep 1, 2023 that will close this issue
@pitkant pitkant moved this from In progress to Done in eurostat 4.0.0 Sep 22, 2023
@pitkant
Copy link
Member Author

pitkant commented Dec 20, 2023

Closed with the CRAN release of package version 4.0.0

@pitkant pitkant closed this as completed Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants