Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix title-code mismatch, add attribution #270

Merged
merged 35 commits into from Sep 27, 2023
Merged

Fix title-code mismatch, add attribution #270

merged 35 commits into from Sep 27, 2023

Conversation

pitkant
Copy link
Member

@pitkant pitkant commented Aug 18, 2023

Related to issue #268

  • Add attribution to European Commission as in data.europa.eu example (I asked Eurostat used support for clarification whether this is needed)
  • Fix mismatches between dataset titles and codes

Still using RefManageR as removing it would need more discussion and possibly deprecation warnings

@pitkant pitkant added this to In progress in eurostat 4.0.0 Aug 18, 2023
@pitkant pitkant linked an issue Aug 23, 2023 that may be closed by this pull request
Enhance search_eurostat(), TOC handling, documentation
@pitkant pitkant linked an issue Sep 13, 2023 that may be closed by this pull request
@pitkant pitkant marked this pull request as ready for review September 26, 2023 13:05
@pitkant
Copy link
Member Author

pitkant commented Sep 26, 2023

I think this PR has become extensive enough and it should be merged to v4-dev. I have documented the changes in NEWS but here are some highlights:

New functions:

  • list_eurostat_cache_items()
  • get_eurostat_folder()
  • toc_count_whitespace()
  • toc_determine_hierarchy()
  • toc_count_children()
  • toc_list_children()
  • label_eurostat_vars2() (will replace label_eurostat_vars() shortly)

Old functions with new functionalities:

  • get_eurostat_toc() (multilingual support)
  • set_eurostat_toc() (multilingual support, make.names = TRUE)
  • search_eurostat() (multilingual support, searching codes)
  • get_bibentry() (multilingual support, improving internal logic)

@pitkant
Copy link
Member Author

pitkant commented Sep 27, 2023

I think instead of reviewing this particular PR it would be more fruitful if you can review and test the whole v4-dev branch

@pitkant pitkant merged commit c17e0ca into v4-dev Sep 27, 2023
eurostat 4.0.0 automation moved this from In progress to Done Sep 27, 2023
@pitkant pitkant mentioned this pull request Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Package citation Enhancements to get_bibentry
1 participant