- Fix in FirstBalance Computation field if no date is supplied

CHANGELOG.md

@@ -81,6 +81,7 @@ All notable changes to this project will be documented in this file.
   erp_framework.highchart.js and erp_framework.chartjs.js respectively
 - Fix an issue with Crosstab when there crosstab_compute_remainder = False 
 - Group by and crosstab reports do not need date_field set anymore. Only time series do.
+- Fix in FirstBalance Computation field if no date is supplied
 
 ## [0.7.0]
 

slick_reporting/fields.py

@@ -396,14 +396,19 @@ def prepare(
         **kwargs,
     ):
         extra_filters = kwargs_filters or {}
-
-        from_date_value = extra_filters.get(f"{self.date_field}__gte")
-        extra_filters.pop(f"{self.date_field}__gte", None)
-        extra_filters[f"{self.date_field}__lt"] = from_date_value
+        if self.date_field:
+            from_date_value = extra_filters.get(f"{self.date_field}__gte")
+            extra_filters.pop(f"{self.date_field}__gte", None)
+            extra_filters[f"{self.date_field}__lt"] = from_date_value
         return super(FirstBalanceField, self).prepare(
             q_filters, kwargs_filters, main_queryset, group_by, prevent_group_by, **kwargs
         )
 
+    def resolve(self, prepared_results, required_computation_results: dict, current_pk, current_row=None) -> float:
+        if not self.date_field:
+            return 0
+        return super().resolve(prepared_results, required_computation_results, current_pk, current_row)
+
 
 field_registry.register(FirstBalanceField)
 

tests/report_generators.py

@@ -108,9 +108,14 @@ class CrosstabOnTraversingField(ReportGenerator):
 
 class ClientTotalBalance(ReportGenerator):
     report_model = SimpleSales
-    date_field = "doc_date"
+    # date_field = "doc_date"
     group_by = "client"
-    columns = ["slug", "name", "__balance__", "__total__"]
+    columns = [
+        "slug",
+        "name",
+        "__balance__",
+        ComputationField.create(Sum, "value", name="__total__", verbose_name=_("Sales")),
+    ]
 
 
 class TotalBalanceWithQueryset(ReportGenerator):