Allow user to choose whether or not the parent view controller should be scaled #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e, but that give user the option to not scale the from view controller.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fantastic library, but for my case, I didn't want the fromVC (Parent View Controller) to scale because it looked awkward given my situation. The following code is completely backwards compatible, so anyone gets these changes won't see their code break.
I contemplated whether I should simply ask the user if they want the parent view controller to be scaled or if I should allow them to pass in a CGFloat which defines the scale (by default, you choose 0.85, but the user would be able to choose 1, 0.90, 0.50, etc.). I decided to go against that because while it is simple to introduce, I'd like to think the library as it stands is pretty awesome :).