Update InlinePickerRowFormer.swift - system version check

[yaricom]

When trying to compare current system version against lowest supported "8.0.0" you should use .OrderedDescending instead of .OrderedAscending, because system version must be higher or equal to the specified one.

[ra1028]

See #30 plz.

[yaricom]

Yes, due to error in system version check it works on iOS with version >= 8.0 not as expected.
I.e. $0.cell.pickerView.reloadAllComponents() is not invoked.

[mattjgalloway]

Shouldn't it actually be != .OrderedAscending?

And yes, @yaricom is right, we need this.

[mattjgalloway]

Note that the PR needs changing anyway because the enum changed with Swift 3. But same problem.

[mattjgalloway]

Ah I see you removed this code now @ra1028. I believe that's wrong. The check was the wrong way round in the first place, so while you removed iOS 7 support, you thought you were doing the right thing, but actually the call needs to be there. reloadAllComponents was iOS 8+, so you were attempting to gate it out for iOS 7. But in face you were gating it in for iOS 7 before - which would have caused a crash.

Anyhow, we need the reloadAllComponents in there.

[ZacharyKhan]

Any updates on this? Still having the same issue over a year later 👎

[mattjgalloway]

@ZacharyKhan I would suggest submitting a new PR with the reloadAllComponents added back in.

[ZacharyKhan]

@mattjgalloway Working on that as I type this 👍 Should be in within an hour. I've also made some other changes that will be noted.

EDIT: Submitted as PR #64

[ra1028]

Thank you for PR! @ZacharyKhan
and thanks for the comment. @mattjgalloway

But I'm losing motivation to maintain the Former now.
So, may I invite to the Coraborators of Former repo?

[ZacharyKhan]

Feel free to invite me, I’d be happy to help out where I’m able.

[ra1028]

@ZacharyKhan
Thanks!
I've sent you an invitation now.
Please go right ahead about to push the commits, merge PR and so on!

[ZacharyKhan]

Closing, #64 has been merged to master & this has conflicts with master branch.