Skip to content
This repository has been archived by the owner on Dec 6, 2021. It is now read-only.

Current Implementation not working on windows (related to child_process.spawn) #9

Closed
Raagh opened this issue Mar 4, 2019 · 4 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@Raagh
Copy link
Owner

Raagh commented Mar 4, 2019

Problem: the current implementation is not working on windows. child_process.spawn from node.js throws an error when trying to lunch angular by ng tests in a command line. On linux and MacOS it works fine.

On windows it works fine if you replace spawn by exec (but we cannot use this as it brings bigger problems)

Repro steps:
Clone repo with branch bugfix/not-working-on-windows
Start application on windows you will see this error in console after angular starts.

capture

@Raagh Raagh added the bug Something isn't working label Mar 4, 2019
@Raagh Raagh assigned Raagh and unassigned Raagh Mar 4, 2019
@Raagh
Copy link
Owner Author

Raagh commented Mar 4, 2019

in case you wanna give it a try @hbenl ! . no compromise 👍

@Raagh Raagh added this to the 1.0 release milestone Mar 4, 2019
@Raagh Raagh added the help wanted Extra attention is needed label Mar 4, 2019
@hbenl
Copy link
Contributor

hbenl commented Mar 5, 2019

Wow, I was not aware how broken spawn is on Windows! There is even a project trying to fix all the bugs. But even that doesn't solve this issue which seems to come from spawn being unable to create the IPC channel on Windows.

@Raagh
Copy link
Owner Author

Raagh commented Mar 5, 2019

@hbenl yes I was surprised too. There's tons of people having the same issue, also found that project but indeed it doesn't help us in this case. Thank you very much for your changes. I will try your pull request when I get home and see what we can do too make it work.

@Raagh
Copy link
Owner Author

Raagh commented Mar 12, 2019

@hbenl made some major changes to fix it, there is now a new way loading and running test much more similar to the one you have in other adapters and working great. also we re back on spawn with socket.io.

@Raagh Raagh closed this as completed Mar 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants