-
-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Could not find Navigator with name "BottomSheetNavigator". You must call NavController.addNavigator() for each navigation type #532
Comments
@raamcosta |
I'm not sure what it could be but we have plenty of bottom sheet usage examples in samples working fine. I'm closing as I don't think we have an issue and I don't know how else to help here, but let me know if you still feel this is something this library is responsible for. |
Hello, I just got the same issue, I have logged the
And when called
EDIT: I think I found why, I'm in the process of upgrading my compose version and compose-destinations was still an old version using accompanist.navigation instead of material.navigation EDIT2: Even thought I have updated to 1.10.2 I'm still getting this crash. |
i'm using the following dependency
io.github.raamcosta.compose-destinations:animations-core and
io.github.raamcosta.compose-destinations:core
the code looks something like this
crash log :
ava.lang.IllegalStateException: Could not find Navigator with name "BottomSheetNavigator". You must call NavController.addNavigator() for each navigation type.
androidx.navigation.NavigatorProvider.getNavigator(NavigatorProvider.kt:67)
androidx.navigation.NavigatorProvider.getNavigator(NavigatorProvider.kt:49)
com.google.accompanist.navigation.material.NavGraphBuilderKt.bottomSheet(NavGraphBuilder.kt:60)
com.ramcosta.composedestinations.spec.DestinationStyleBottomSheetKt.addComposable(DestinationStyleBottomSheet.kt:52)
com.ramcosta.composedestinations.animations.AnimatedNavHostEngineKt$lambda$1.invoke(AnimatedNavHostEngine.kt:58)
com.ramcosta.composedestinations.animations.AnimatedNavHostEngineKt$lambda$1.invoke(AnimatedNavHostEngine.kt:57)
com.ramcosta.composedestinations.spec.DestinationStyleKt.addActivityDestination(DestinationStyle.kt:220)
com.ramcosta.composedestinations.DefaultNavHostEngine.composable(DefaultNavHostEngine.kt:123)
com.ramcosta.composedestinations.DestinationsNavHostKt.addNavGraphDestinations(DestinationsNavHost.kt:115)
com.ramcosta.composedestinations.DestinationsNavHostKt.access$addNavGraphDestinations(DestinationsNavHost.kt:1)
com.ramcosta.composedestinations.DestinationsNavHostKt$DestinationsNavHost$2.invoke(DestinationsNavHost.kt:77)
com.ramcosta.composedestinations.DestinationsNavHostKt$DestinationsNavHost$2.invoke(DestinationsNavHost.kt:71)
androidx.navigation.compose.NavHostKt.NavHost(NavHost.kt:395)
com.ramcosta.composedestinations.DefaultNavHostEngine.NavHost(DefaultNavHostEngine.kt:79)
com.ramcosta.composedestinations.DestinationsNavHostKt.DestinationsNavHost(DestinationsNavHost.kt:71)
com.navi.pay.onboarding.binding.ui.NaviPayOnboardingActivity$onCreate$1$1.invoke(NaviPayOnboardingActivity.kt:35)
com.navi.pay.onboarding.binding.ui.NaviPayOnboardingActivity$onCreate$1$1.invoke(NaviPayOnboardingActivity.kt:34)
androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:108)
androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:35)
androidx.compose.material.MaterialTheme_androidKt.PlatformMaterialTheme(MaterialTheme.android.kt:23)
androidx.compose.material.MaterialThemeKt$MaterialTheme$1$1.invoke(MaterialTheme.kt:82)
androidx.compose.material.MaterialThemeKt$MaterialTheme$1$1.invoke(MaterialTheme.kt:81)
androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:108)
androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:35)
androidx.compose.runtime.CompositionLocalKt.CompositionLocalProvider(CompositionLocal.kt:228)
androidx.compose.material.TextKt.ProvideTextStyle(Text.kt:396)
androidx.compose.material.MaterialThemeKt$MaterialTheme$1.invoke(MaterialTheme.kt:81)
androidx.compose.material.MaterialThemeKt$MaterialTheme$1.invoke(MaterialTheme.kt:80)
androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:108)
androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:35)
androidx.compose.runtime.CompositionLocalKt.CompositionLocalProvider(CompositionLocal.kt:228)
androidx.compose.material.MaterialThemeKt.MaterialTheme(MaterialTheme.kt:72)
com.navi.pay.common.theme.NaviPayThemeKt.NaviPayMaterialTheme(NaviPayTheme.kt:38)
com.navi.pay.onboarding.binding.ui.NaviPayOnboardingActivity$onCreate$1.invoke(NaviPayOnboardingActivity.kt:34)
com.navi.pay.onboarding.binding.ui.NaviPayOnboardingActivity$onCreate$1.invoke(NaviPayOnboardingActivity.kt:33)
androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:108)
androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:35)
androidx.compose.ui.platform.ComposeView.Content(ComposeView.android.kt:428)
androidx.compose.ui.platform.AbstractComposeView$ensureCompositionCreated$1.invoke(ComposeView.android.kt:252)
androidx.compose.ui.platform.AbstractComposeView$ensureCompositionCreated$1.invoke(ComposeView.android.kt:251)
androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:108)
androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:35)
androidx.compose.runtime.CompositionLocalKt.CompositionLocalProvider(CompositionLocal.kt:228)
androidx.compose.ui.platform.CompositionLocalsKt.ProvideCommonCompositionLocals(CompositionLocals.kt:195)
androidx.compose.ui.platform.AndroidCompositionLocals_androidKt$ProvideAndroidCompositionLocals$3.invoke(AndroidCompositionLocals.android.kt:119)
androidx.compose.ui.platform.AndroidCompositionLocals_androidKt$ProvideAndroidCompositionLocals$3.invoke(AndroidCompositionLocals.android.kt:118)
androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:108)
androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:35)
androidx.compose.runtime.CompositionLocalKt.CompositionLocalProvider(CompositionLocal.kt:228)
androidx.compose.ui.platform.AndroidCompositionLocals_androidKt.ProvideAndroidCompositionLocals(AndroidCompositionLocals.android.kt:110)
androidx.compose.ui.platform.WrappedComposition$setContent$1$1$2.invoke(Wrapper.android.kt:158)
androidx.compose.ui.platform.WrappedComposition$setContent$1$1$2.invoke(Wrapper.android.kt:157)
androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:108)
androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:35)
androidx.compose.runtime.CompositionLocalKt.CompositionLocalProvider(CompositionLocal.kt:228)
androidx.compose.ui.platform.WrappedComposition$setContent$1$1.invoke(Wrapper.android.kt:157)
androidx.compose.ui.platform.WrappedComposition$setContent$1$1.invoke(Wrapper.android.kt:142)
androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:108)
androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:35)
androidx.compose.runtime.ActualJvm_jvmKt.invokeComposable(ActualJvm.jvm.kt:78)
androidx.compose.runtime.ComposerImpl.doCompose(Composer.kt:3340)
androidx.compose.runtime.ComposerImpl.composeContent$runtime_release(Composer.kt:3273)
androidx.compose.runtime.CompositionImpl.composeContent(Composition.kt:588)
androidx.compose.runtime.Recomposer.composeInitial$runtime_release(Recomposer.kt:1013)
androidx.compose.runtime.CompositionImpl.setContent(Composition.kt:520)
androidx.compose.ui.platform.WrappedComposition$setContent$1.invoke(Wrapper.android.kt:142)
androidx.compose.ui.platform.WrappedComposition$setContent$1.invoke(Wrapper.android.kt:133)
androidx.compose.ui.platform.AndroidComposeView.setOnViewTreeOwnersAvailable(AndroidComposeView.android.kt:1191)
androidx.compose.ui.platform.WrappedComposition.setContent(Wrapper.android.kt:133)
androidx.compose.ui.platform.WrappedComposition.onStateChanged(Wrapper.android.kt:183)
androidx.lifecycle.LifecycleRegistry$ObserverWithState.dispatchEvent(LifecycleRegistry.kt:314)
androidx.lifecycle.LifecycleRegistry.addObserver(LifecycleRegistry.kt:192)
androidx.compose.ui.platform.WrappedComposition$setContent$1.invoke(Wrapper.android.kt:140)
androidx.compose.ui.platform.WrappedComposition$setContent$1.invoke(Wrapper.android.kt:133)
androidx.compose.ui.platform.AndroidComposeView.onAttachedToWindow(AndroidComposeView.android.kt:1266)
android.view.View.dispatchAttachedToWindow(View.java:21092)
android.view.ViewGroup.dispatchAttachedToWindow(ViewGroup.java:3501)
android.view.ViewGroup.dispatchAttachedToWindow(ViewGroup.java:3508)
android.view.ViewGroup.dispatchAttachedToWindow(ViewGroup.java:3508)
android.view.ViewGroup.dispatchAttachedToWindow(ViewGroup.java:3508)
android.view.ViewGroup.dispatchAttachedToWindow(ViewGroup.java:3508)
... 18 more
The text was updated successfully, but these errors were encountered: