Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DestinationStyle.Dialog with usePlatformDefault properties causes wrong dialog measuring at some devices #536

Closed
wellwhatever opened this issue Nov 7, 2023 · 1 comment

Comments

@wellwhatever
Copy link

wellwhatever commented Nov 7, 2023

Hi, I have dialog with properties where usePlatformDefaultWith is set to false, so that it 'acts' like full-screen dialog. I noticed a problem on specific devices, that the size of this dialog is calculated wrong when this property is set to false. Tested on: SM S20FE, A13

That is the style that I use:

object FullScreenDialog : DestinationStyle.Dialog {
    override val properties = DialogProperties(
        usePlatformDefaultWidth = false,
    )
}

And that's how I use it:

@Destination(style = FullScreenDialog::class)
@Composable
fun MyDialog(){
Box(){...}
}

Screenshot 2023-11-07 at 10 05 45

Screenshot is kinda ugly, but anyway it is clearly visible that this dialog is bigger then the viewport.

@raamcosta
Copy link
Owner

Hi!

This is not something we can control on compose destinations library.
We’re simply calling the official APIs with these parameters, so you’d have to open an issue for the official compose navigation library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants